search

erlangbureau / jamdb_oracle

Oracle Database driver for Erlang
MIT License
106 stars 48 forks source link

Elixir 17 fixes for charlist sigils #180

Closed sax closed 2 months ago

sax commented 3 months ago

Elixir 1.17 formats charlists with sigil_c. The connection error that is returned when encountering constraint errors seems to inspect the charlist, so the string is formatted as "~c\"ORA-ERR: message\"". Because of this, unique_constraint was not respected in Elixir 1.17 because the constraints errors messages could not be matched.

In addition, I fixed some deprecation warnings about creating charlists without sigil_c. That sigil was introduced in Elixir 1.9, so it should not be a breaking change based on the versions that this library declares it supports.

sax commented 2 months ago

Any possibility of merging, or at least taking a look and running the workflow? This bug makes it impossible for Ecto to recover from things like constraint errors.

vstavskyi commented 2 months ago

Thanks

sax commented 2 months ago

Thank you! I really appreciate the time that you all took to build and release this library; it's been extremely helpful for me and the team I'm working with.