search

erlangbureau / jamdb_oracle

Oracle Database driver for Erlang
MIT License
106 stars 48 forks source link

please don't log passwords #90

Closed shribe closed 3 years ago

shribe commented 3 years ago

Currently the process for a connection maintains the password in its state forever, and on abnormal termination, such as a SQL error, the state including the password is logged.

I am not familiar with the Oracle protocol, so I don't know if there is any kind of re-auth that would require the password to be maintained after first use. If not, it could simply be cleared from state after use, here. If so, then it could be stripped out in the format_status callback.

For example, this is how postgrex does it.

vstavskyi commented 3 years ago

This can be done in .erl or .ex source files.

How do you create a database connection and create query? Erlang? Elixir DBConnection? Elixir Ecto?

Empty state is returned only once in .erl source file. handle_error(socket, Reason, #oraclient{})

Maybe empty state is needed after specific ORA errors?

vstavskyi commented 3 years ago

Please test master branch with last commits

shribe commented 3 years ago

I will do so today, thank you

-- Scott Ribe @.*** https://www.linkedin.com/in/scottribe/

On Mar 20, 2021, at 2:17 PM, Mykhailo Vstavskyi @.***> wrote:

Please test master branch with last commits