Closed baransu closed 7 years ago
Going to release version 0.3 after this got merged.
Everything looks great, but I have one suggestion: could we make color of outgoing particles different than incoming ones? It's hard to see what's going on if there are a lot of them.
We can treat outgoing messages as warrnings which will make them yellow. There should be another way to do it but I'm not sure right now.
I see. I think it's fine, because we don't specify something like "warning" message or traffic (yet).
I would worry more about incoming traffic than outgoing. The observed node is our concern. The more traffic it gets, the more load it need to handle. Does incoming yellow traffic look good? I can't test right now myself.
I'll test later today and post to YouTube so you can check how it looks 🙂
@michalslaski Here you can see example with Mnesia: https://youtu.be/-AvscsVSyck There is little flickering with bi-directional traffic but it's easier to understand than our previous version.
@Baransu thanks for sharing the video. Do you know why the yellow traffic sometimes appears in front of the blue one and sometimes behind it? I don't want to be too picky, but I'm worried people will not focus on what the visualization is trying to explain, instead they will focus on the "special effects".
It may be because of texture overlaping on the z-axis. I'll to look into Vizceral how they handle that.
I've spend around 3 hours debugging Vizceral code but I have no idea how to come up with good solution to this problem. I've also created issue describing this problem.
@michalslaski should we keep that flickering and move on working to Vizceral fix or should we make all messages the same color?
@Baransu I suggest to keep the same color until the "special effect" is fixed.
Do I understand it correctly that if we would merge this PR we have:
Correct
I'm merging it and releasing version 0.3
Fixes: #29 Few days ago I've send PR to Vizceral. Proposed changes were merged and released as 4.4.0.
vizceral-react
version to 4.4.0