search

erlanglab / erlangpl

Tool for developers working with systems running on the Erlang VM (BEAM). It helps with performance analysis.
http://www.erlang.pl/
Apache License 2.0
546 stars 40 forks source link

Update traffic data #39

Closed baransu closed 7 years ago

baransu commented 7 years ago

Fixes: #24 and https://github.com/erlanglab/erlangpl-ui/issues/29 Few days ago I've send PR to Vizceral. Proposed changes were merged and released as 4.4.0.

All changes are awesome but there is only one regression - rps is calculated by Vizceral only based on outgoing messages so our displayed rps is incorrect. I'm wondering how big this issue is.

arkgil commented 7 years ago

@Baransu which branch of erlangpl-ui should I use with this PR?

baransu commented 7 years ago

update-traffic-to-new-vizceral

arkgil commented 7 years ago

Thanks. It looks beatiful! Gonna test it at work today 😊 Thank you for handling that!

baransu commented 7 years ago

And I'm getting familiar with Erlang code ^^

arkgil commented 7 years ago

Fun fact: when one of clustered nodes is getting killed by OS due to lack of memory, everything crashes 😄 But I think we didn't handle that before either.

But it's great to see OTP in action, restarting the tracer process and trying to recover from failure ❤️

baransu commented 7 years ago

Going to merge it and release as 0.6