search

erlcloud / lhttpc

lhttpc is a lightweight HTTP/1.1 client implemented in Erlang.
Other
1 stars 19 forks source link

crypto:rand_bytes/1 was removed in 20.0+ #14

Closed danieljharris closed 6 years ago

danieljharris commented 6 years ago 
_build/default/lib/lhttpc/src/lhttpc_manager.erl:270: Warning: call to crypto:rand_bytes/1 will fail, since it was removed in 20.0; use crypto:strong_rand_bytes/1
nalundgaard commented 6 years ago

Ignore the warning. It's there for compatibility. Read the code: it's a fallback.

nalundgaard commented 6 years ago

@danieljharris just for clarity: the guard lists:member({seed,1}, ssl:module_info(exports)) is always false for Erlang 20. It looks like the function was removed in R15, actually, the last tag I see with it is OTP_R14B04.

So this is harmless. @motobob should we just delete this whole block?

motobob commented 6 years ago

yeah, let's clean it all up. R16 is the oldest thing i care.