search

erleans / pgo

Erlang Postgres client and connection pool
Apache License 2.0
80 stars 16 forks source link

Fix SSL connection #16

Closed benbro closed 5 years ago

tsloughter commented 5 years ago

Cool, thanks. I was going to put the module name (ssl or gen_tcp) in #conn{} instead of using a separate socket module as the full solution. Would you be interested in doing that or should I merge this and then make a new patch tat replaces pgo_socket with the variable carrying around the right module to call.

benbro commented 5 years ago

I'm not sure that transport_module=ssl/gen_tcp is enough because you need to change gpo_handler:close/1 as well. Maybe it's better that you'll make the changes according to your style. I don't care about attribution :)