fix: add pool_options to options()

erleans / pgo

Erlang Postgres client and connection pool

Apache License 2.0

80 stars 16 forks source link

Closed jakobsvenning closed 2 days ago

jakobsvenning commented 3 years ago

The pool_options field is missing in the options() type.
timeout is a valid pool_option(), see https://github.com/erleans/pgo/blob/master/src/pgo.erl#L95.

tsloughter commented 3 years ago

Hm, it looks like CI isn't running.

jakobsvenning commented 3 years ago

Hm, it looks like CI isn't running.

Have you enabled your ci workflow to run on forked PRs? It's not enabled by default, see https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories.

tsloughter commented 2 days ago

Just merged a PR that fixed this. Thanks!