search

erleans / pgo

Erlang Postgres client and connection pool
Apache License 2.0
80 stars 16 forks source link

IPv6 support #55

Closed lpil closed 2 years ago

lpil commented 2 years ago

🚧

tsloughter commented 2 years ago

Could you make this take a general list of socket options like Postgrex does?

lpil commented 2 years ago

Yes certainly, though I've not managed to get this to work with this approach or the equivilent when passing a list of options. I've tested with an application that runs both PGO and Postgrex with the same configuration. Postgrex succeeds but PGO fails. I can't immediately see any difference between how they use gen_tcp:connect so I'm not sure what the issue might be.

lpil commented 2 years ago

@tsloughter How does this look now?

lpil commented 2 years ago

@tsloughter ping :)

tsloughter commented 2 years ago

Oh, sorry, I forgot this wasn't the issue but an PR that was ready to go :). Will get it merged. Thanks!

tsloughter commented 2 years ago

I'll merge it but weird the CI isn't running.

lpil commented 2 years ago

💜