erleben / OpenTissue

OpenTissue is a collection of generic algorithms and data structures for rapid development of interactive modeling and simulation.
http://www.opentissue.org
95 stars 26 forks source link

Remove install rules from tests and demos #21

Open ricortiz opened 4 years ago

ricortiz commented 4 years ago

Arguably the OT distribution package should only contain the library itself and the CMake machinery find the package and import the OpenTissue target. If users want to run demos then we should instruct them to go over the build process.

@erleben Thoughts?

erleben commented 4 years ago

I agree with you that OT library + CMake is the main parts that make up an OT package.

I am thinking Conan part can be incorporated into the CMake magic workflow. Either guiding users by introspection and meaningful warnings or simply running the Conan install think as a pre-step for the whole CMake thing.

I am also thinking that there are deps on two different levels, those that are used by OT library functions and those that are used by demos/unit-tests. I am in two minds whether they should be treated independently.

erleben commented 4 years ago

That is I support nuking the install rules for unit-tests and demos

ricortiz commented 4 years ago

Conan can indeed be incorporated into the CMake build system. I have been thinking on a way to do it that will also allow folks to build OT aps without conan.

Ref.

Launch conan from within cmake.

ricortiz commented 4 years ago

So here is the dependency breakdown as I see it:

erleben commented 4 years ago

We got a bit of devIL as well?

erleben commented 4 years ago

The Conan cmake integration seems like a nice solution. It will make it easier for new unexperienced C++ developers to get into OT. Experienced developers can always just dig into the nasty parts, no need to worry about them:-)

ricortiz commented 4 years ago

yeah, forgot DevIL...