search

erleben / OpenTissue

OpenTissue is a collection of generic algorithms and data structures for rapid development of interactive modeling and simulation.
http://www.opentissue.org
95 stars 26 forks source link

Have some questions #3

Closed LinLorry closed 4 years ago

LinLorry commented 5 years ago

https://github.com/erleben/OpenTissue/blob/ca311cee7ea6f4352a1dc14fdeed0dda57aa7c37/OpenTissue/core/math/math_random.h#L60

When i use this header, i get some errors. I can't find this 'details', but i find 'detail' in there. https://github.com/erleben/OpenTissue/blob/ca311cee7ea6f4352a1dc14fdeed0dda57aa7c37/OpenTissue/core/math/math_constants.h#L24

Maybe somewhere else have 'details', can you give me some suggests? Though i use detail::zero() and detail::one() replace original, it also can work.

erleben commented 5 years ago

It appears to be a typo. The namespace should be "detail" and not "details"

Thx for reporting this.

On Thu, Jul 4, 2019 at 4:55 AM LinLorry notifications@github.com wrote:

https://github.com/erleben/OpenTissue/blob/ca311cee7ea6f4352a1dc14fdeed0dda57aa7c37/OpenTissue/core/math/math_random.h#L60

When i use this header, i get some errors. I can't find this 'details', but i find 'detail' in there.

https://github.com/erleben/OpenTissue/blob/ca311cee7ea6f4352a1dc14fdeed0dda57aa7c37/OpenTissue/core/math/math_constants.h#L24

Maybe somewhere else have 'details', can you give me some suggests? Though i use detail::zero() and detail::one() replace original, it also can work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/erleben/OpenTissue/issues/3?email_source=notifications&email_token=ACYEH267EBP6WM2SEK3SGV3P5VRCFA5CNFSM4H5QUX5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5ITZIA, or mute the thread https://github.com/notifications/unsubscribe-auth/ACYEH2357UOFYIGOZNW3SI3P5VRCFANCNFSM4H5QUX5A .

LinLorry commented 5 years ago

ok, thank you, i can fix by myself