erlef / docker-elixir

Official Docker image for Elixir :whale: :turtle: :rocket:

http://elixir-lang.org/

50 stars 20 forks source link

Docker image for Elixir 1.13.4 and Erlang 23 #67

Closed tripathy-rakesh1 closed 1 year ago

tripathy-rakesh1 commented 1 year ago

Proposing Docker file for Elixir 1.13.4 and Erlang 23-slim

duksis commented 1 year ago

I assume this PR is aimed to close https://github.com/erlef/docker-elixir/issues/65

shouldn't this file be located in a folder otp-23-slim instead of just otp-23? if there is a otp-23-slim wouldn't it make sense to have otp-23 and otp-23-alpine as well?

when introducing a new OTP version does it make sense to add tests for it as well? https://github.com/erlef/docker-elixir/blob/master/.github/workflows/elixir.yaml#L11

getong commented 1 year ago

generate-stackbrew-library.sh needs to add otp-23-slim.

getong commented 1 year ago

67 #69 should be made into one pr, and rebase into one commit.

getong commented 1 year ago

Would you rebase into one commit?

tripathy-rakesh1 commented 1 year ago

https://github.com/erlef/docker-elixir/pull/69 has been closed and no longer required, can we proceed further with one PR https://github.com/erlef/docker-elixir/pull/67 .

getong commented 1 year ago

I make docker-library/official-images#14527 , and this pr is merged.