Closed paulswartz closed 11 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/oidcc_profile.erl | 44 | 45 | 97.78% | ||
src/oidcc_token.erl | 13 | 14 | 92.86% | ||
src/oidcc_authorization.erl | 18 | 21 | 85.71% | ||
<!-- | Total: | 100 | 105 | 95.24% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/oidcc_token.erl | 1 | 88.46% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 142: | 0.8% |
Covered Lines: | 892 |
Relevant Lines: | 949 |
should this split the profile atoms into fapi2_security_profile and fapi2_message_signing?
That would probably be good. FAPI1 also has very different requirements between the specs.
@paulswartz mTLS should be relatively simple to handle:
The user can already supply ssl
options. If you include cert[file]
, key[file]
and verify: :verify_peer
, mTLS is enabled.
So we can just verify that they either are set, tls_client_auth
is supported by the provider and otherwise require DPoP.
After this minor correction good for merge.
@paulswartz Can you open issues for all the TODOs that are missing for full compliance? (Like JARM and mTLS)
@paulswartz Can you run mix format
so that I can merge?
Ref: https://github.com/erlef/oidcc/discussions/316
Open Questions
fapi2_security_profile
andfapi2_message_signing
? The latter seems to also require request objects and JARM (even if the conformance suite doesn't seem to).TODO