erlef / oidcc

OpenId Connect client library in Erlang & Elixir
https://hexdocs.pm/oidcc
Apache License 2.0
184 stars 49 forks source link

FAPI2 profile support #317

Closed paulswartz closed 11 months ago

paulswartz commented 11 months ago

Ref: https://github.com/erlef/oidcc/discussions/316

Open Questions

TODO

coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 132


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/oidcc_profile.erl 44 45 97.78%
src/oidcc_token.erl 13 14 92.86%
src/oidcc_authorization.erl 18 21 85.71%
<!-- Total: 100 105 95.24% -->
Files with Coverage Reduction New Missed Lines %
src/oidcc_token.erl 1 88.46%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 142: 0.8%
Covered Lines: 892
Relevant Lines: 949

💛 - Coveralls
maennchen commented 11 months ago

should this split the profile atoms into fapi2_security_profile and fapi2_message_signing?

That would probably be good. FAPI1 also has very different requirements between the specs.

maennchen commented 11 months ago

@paulswartz mTLS should be relatively simple to handle:

The user can already supply ssl options. If you include cert[file], key[file] and verify: :verify_peer, mTLS is enabled.

So we can just verify that they either are set, tls_client_auth is supported by the provider and otherwise require DPoP.

maennchen commented 11 months ago

After this minor correction good for merge.

maennchen commented 11 months ago

@paulswartz Can you open issues for all the TODOs that are missing for full compliance? (Like JARM and mTLS)

maennchen commented 11 months ago

@paulswartz Can you run mix format so that I can merge?