erlef / oidcc

OpenId Connect client library in Erlang & Elixir
https://hexdocs.pm/oidcc
Apache License 2.0
166 stars 44 forks source link

Support `application/jwk-set+json` content-type #352

Closed caioaao closed 4 months ago

caioaao commented 4 months ago

Some providers will return this content-type, which is just a JSON content-type with stronger guarantees, so it's safe to just treat it as regular JSON

https://webconcepts.info/concepts/media-type/application/jwk-set+json

maennchen commented 4 months ago

RFC for mime type: https://www.rfc-editor.org/rfc/rfc7517.html#section-8.5.1

caioaao commented 4 months ago

@maennchen seems like there's some instability in github's network, that's why the tests failed. It seems like I can't re-run them, though

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 177

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/oidcc_http_util.erl 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/oidcc_provider_configuration_worker.erl 1 96.3%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 171: -0.2%
Covered Lines: 1062
Relevant Lines: 1152

💛 - Coveralls
maennchen commented 4 months ago

Thanks @caioaao ❤️