search

erlef / oidcc

OpenId Connect client library in Erlang & Elixir
https://hexdocs.pm/oidcc
Apache License 2.0
184 stars 49 forks source link

build: update elixir tool version #387

Closed dustinfarris closed 1 month ago

dustinfarris commented 1 month ago

The default 1.17.2 version from hex is built with OTP 25. mix test has a failure with this version. 

  1) test &Oidcc.client_credentials_token/2 works (Oidcc.TokenTest)
     test/oidcc/token_test.exs:211
     match (=) failed
     code:  assert {:ok, %Token{}} =
              Oidcc.Token.client_credentials(
                client_context,
                %{scope: ["openid"]}
              )
     left:  {:ok, %Oidcc.Token{}}
     right: {:error, :no_matching_key}
     stacktrace:
       test/oidcc/token_test.exs:224: (test)

Updating to the OTP 27 build resolves this issue.

maennchen commented 1 month ago

@dustinfarris It seems unlikely, that this test is broken by that. Are you sure it’s not just flaky?

dustinfarris commented 1 month ago

@dustinfarris It seems unlikely, that this test is broken by that. Are you sure it’s not just flaky?

You are correct. It is flaky.

maennchen commented 1 month ago

@dustinfarris Can you open an issue about the test? We shouldn’t have flaky tests either…

dustinfarris commented 1 month ago

@dustinfarris Can you open an issue about the test? We shouldn’t have flaky tests either…

389