search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Should the ebin version be checked? #14

Closed Licenser closed 5 years ago

Licenser commented 9 years ago

The hex plugin still checks ./ebin/*.app for the app version during publish and cut, how I understand it with rebar3 that should all be in _build/default/...

This difference in behavior can lead to some confusion when a old ebin folder exists and cut/publish refuses to pick up the new version that rebar3 already knows about.

tsloughter commented 9 years ago

The plugin isn't the one responsible for "checking" the app file. It uses rebar_app_info to get the vsn. Which can't know if ebin/*.app is accurate or not and has to assume it is if it exists.

starbelly commented 5 years ago

@tsloughter Can this be closed?

tsloughter commented 5 years ago

Yea, I think so.