search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Apply rebar3_hank and clean dead code #220

Closed pbrudnick closed 3 years ago

pbrudnick commented 3 years ago

This was the rebar3_hank output:

$ rebar3 hank
===> Failed to restore /Users/pablo/dev/rebar3_hex/_build/default/plugins/.rebar3/rebar_compiler_erl/source_apps.dag file. Discarding it.

===> Analyzing applications...
===> Compiling covertool
===> Looking for code to kill with fire...
===> The following pieces of code are dead and should be removed:
test/support/hex_api_model.erl:19: ?JSON_MIME is unused
src/rebar3_hex_user.erl:21: ?ENDPOINT is unused
src/rebar3_hex_io.erl:27: ?OP_PUTC is unused
src/rebar3_hex_docs.erl:13: ?ENDPOINT is unused
src/rebar3_hex_cut.erl:12: ?ENDPOINT is unused
test/rebar3_hex_user_SUITE.erl:37: format_error_test/1 doesn't need its #1 argument
test/rebar3_hex_user_SUITE.erl:24: encrypt_decrypt_write_key_test/1 doesn't need its #1 argument
test/rebar3_hex_user_SUITE.erl:10: init_test/1 doesn't need its #1 argument
test/rebar3_hex_publish_SUITE.erl:90: format_error_test/1 doesn't need its #1 argument
test/rebar3_hex_owner_SUITE.erl:10: format_error_test/1 doesn't need its #1 argument
test/rebar3_hex_integration_SUITE.erl:400: reset_password_unhandled_test/1 doesn't need its #1 argument
test/rebar3_hex_integration_SUITE.erl:344: whoami_unhandled_test/1 doesn't need its #1 argument
test/rebar3_hex_integration_SUITE.erl:201: decrypt_write_key_test/1 doesn't need its #1 argument
test/rebar3_hex_integration_SUITE.erl:107: sanity_check/1 doesn't need its #1 argument
test/rebar3_hex_integration_SUITE.erl:74: end_per_testcase/2 doesn't need its #1 argument
test/rebar3_hex_integration_SUITE.erl:69: init_per_testcase/2 doesn't need its #1 argument
test/rebar3_hex_file_SUITE.erl:10: expand_paths_test/1 doesn't need its #1 argument
test/rebar3_hex_docs_SUITE.erl:10: format_error_test/1 doesn't need its #1 argument
test/rebar3_hex_config_SUITE.erl:21: repo/1 doesn't need its #1 argument
test/rebar3_hex_config_SUITE.erl:14: org_key_name_test/1 doesn't need its #1 argument
test/rebar3_hex_config_SUITE.erl:10: api_key_name_test/1 doesn't need its #1 argument
test/rebar3_hex_client_SUITE.erl:15: pretty_print_status/1 doesn't need its #1 argument
test/rebar3_hex_client_SUITE.erl:11: pretty_print_errors/1 doesn't need its #1 argument
test/rebar3_hex_SUITE.erl:35: help_test/1 doesn't need its #1 argument
test/rebar3_hex_SUITE.erl:30: init_test/1 doesn't need its #1 argument
test/rebar3_hex_SUITE.erl:26: repo_opt/1 doesn't need its #1 argument
test/rebar3_hex_SUITE.erl:17: task_args_test/1 doesn't need its #1 argument
test/rebar3_hex_SUITE.erl:11: gather_opts_test/1 doesn't need its #1 argument
src/rebar3_hex_revert.erl:77: revert/4 doesn't need its #4 argument
src/rebar3_hex.hrl:1: ?DEFAULT_FILES is used only at src/rebar3_hex_publish.erl
starbelly commented 3 years ago

Thanks 😄 This looks solid to me! Happy to have hank on board ❤️