erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

CI OTP 24 #229

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

Can't actually remember why I wanted/needed to introduce dialyzer here, but it was somehow on my TODO list.

The proposed changes only work with a yet unreleased hex_core which also caused dialyzer warnings, but is a good preview of what's to come.

Here it is:

Opening as draft for the above mentioned reasons.

Commenting on the stuff that might not be so obvious (or on which I have doubts).

paulo-ferraz-oliveira commented 3 years ago

Following https://github.com/erlef/rebar3_hex/pull/232, this has been rebased on top of master. Initial conditions, https://github.com/erlef/rebar3_hex/pull/229#issue-648967795, still apply, though.

paulo-ferraz-oliveira commented 3 years ago

hexpm/hex_core#121 was merged and tagged, so I pushed a remade rebar.lock. After jelly-beam/verl#21, CI should be all 🟢. I've been testing this locally with _checkouts.

paulo-ferraz-oliveira commented 3 years ago

jelly-beam/verl#21 was merged and tagged, so I pushed a remade rebar.lock. If CI's Okay that does it for my change 😄

paulo-ferraz-oliveira commented 3 years ago

I also fixed coverage stuff. It was hidden by the fact it didn't show an error. But look at README and see it's not there.