search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Change Json to Erlang Media Type #23

Closed yohaneskuma closed 8 years ago

yohaneskuma commented 8 years ago

The dependency towards jsx for encoding and decoding is replaced with Erlang Media Type which uses Maps as data structure. All the side-effects are cleaned.

tsloughter commented 8 years ago

Thanks! There are some indentation issues, like https://github.com/ieug/rebar3_hex/blob/using_erlang_media_type/src/rebar3_hex_user.erl#L169 , could you clean those up and squash the commits?

Only issue I see here is the use of maps that means only 17+ can use the plugin. This is probably fine and actually we may already have only supported R16+ in the first place with this plugin, if I recall it has always failed on R15. But I need to make sure this is the case and is ok.

yohaneskuma commented 8 years ago

I have squashed the indentation issues. I hope it is clean now.