search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Fix crash for "no version for docs" #243

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

This was crashing: I'm not sure whether that's the message you want, though, in rebar3_hex_docs.

Bonus fix was removing an extra s from a log message (in rebar3_hex_error).

Also, should rebar3_hex_error's format_error(Reason) return a string so as to not crash? Or is the crash intended, here?

starbelly commented 3 years ago

Also, should rebar3_hex_error's format_error(Reason) return a string so as to not crash? Or is the crash intended, here?

Forgot to note: We should never crash since this is a user facing application if you will. So, this change is right on the money and inline with many upcoming changes 👍