search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Add build provider #277

Closed starbelly closed 2 years ago

starbelly commented 2 years ago

This is ready but depends on #272 being merged first.

Closes #233

starbelly commented 2 years ago

the _paths variants are clearer, but it's not a super significant difference either way, especially if this ends up using glob > or wildcard patterns (though that's exclude_patterns, which has also been renamed). The "confusion" is already common (e.g. filelib supports is_file|dir|regular already).

I'll add support for _paths but keep in support for the old name.

ferd commented 2 years ago

yeah just supporting newer options without breaking the old stuff is fine, if it's not too much extra complexity. Keep a comment about the reason for it so whoever is still maintaining this in the future has a good contextual clue of the intent behind it.

starbelly commented 2 years ago

Note : I made one more change, in line with the others around name changes (i.e., continue to support exclude_regexps).