search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Only expand once #285

Closed starbelly closed 2 years ago

starbelly commented 2 years ago

I need to add a regression test for this at the very least. Would really like @eproxus to give this a whirl himself as well.

I tested this against the edge case kraft tarball I was given and no more infinite recursion, but would still like further validation (beyond unit tests).

To test this simple go to a project, recreate the scenario per #246 and run mkdir -p tmp && rebar3 hex build package -o tmp

Then inspect the goods.

starbelly commented 2 years ago

Right, coming back to this after a good while, it's not infinite recursion, but if you have a lot of files, it can take a LONG time in addition to ending up with a ton of bogus paths in the results.