search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

rebar3_hex_organization: allow building with OTP-25.0-rc1 #302

Closed mikpe closed 2 years ago

mikpe commented 2 years ago

Attempting to build with OTP-25.0-rc1 throws a warning:

===> Compiling rebar3_hex src/rebar3_hex_organization.erl:391:5: Warning: public_key:ssh_encode/2 is removed; use ssh_file:encode/2 instead

which arguably should have been a hard error since the function is gone.

For some reason the ifdef:ery in rebar3_hex_organization.erl doesn't make the right choice for OTP-25.0-rc1, so I took the opportunity to rewrite it using the standard OTP_RELEASE macro. With this the build succeeds.

starbelly commented 2 years ago

Thanks for the contribution! We'll cut a release by tomorrow. ❤️

starbelly commented 2 years ago

Just noting, needed to get in a bug fix and enhancement before publishing :)

zmstone commented 2 years ago

Hi @starbelly is it ready for a release? if not, need any help?

starbelly commented 2 years ago

@zmstone I think I was waiting on a PR to be merged, but that's not going to happen atm, so I'll cut a release tonight.

starbelly commented 2 years ago

@zmstone https://hex.pm/packages/rebar3_hex/7.0.2 released :)