search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

In GitHub Actions the plugin try push 0.0.0 version #314

Closed vkatsuba closed 2 years ago

vkatsuba commented 2 years ago

Hi All!

By some reason latest version of plugin is try to push into hex.pm version 0.0.0 of application. Here is a link to failed CI where you can see:


Note : In version 7.1 this warning will be treated as an error

===> Getting log of git repo failed in /__w/gtplib/gtplib. Falling back to version 0.0.0
===> gtplib.app.src : invalid license types detected - 'Mozilla Public License 2.0'
     See https://spdx.org/licenses/ for a list of valid license identifiers

===> Getting log of git repo failed in /__w/gtplib/gtplib. Falling back to version 0.0.0

Here is a pipeline for publish package.

Any opinions about it?

Notes: same approach can be used locally and all will works as expected - the issue is related only for GitHub Actions.

Best Regards, --V

starbelly commented 2 years ago

@vkatsuba Hi! 😄

This actually is more related to rebar3 itself. In the run we can see :

Getting log of git repo failed in /__w/gtplib/gtplib. Falling back to version 0.0.0

This comes from rebar_git_resource:make_vsn/2, which rebar3_hex utilizes for getting the git version.

That said, I'm not able to reproduce it locally, but my environment is quite different ofc. I suspect this has something to do with the version of git used by the checkout action, but will have to dig more. There was a change to make_vsn/2 in rebar3 3.14 and the version used by that erlang alpine image is 3.14.3, so possible, but at a quick glance didn't seem to be related.

vkatsuba commented 2 years ago

Hey @starbelly! Thanks for reply. Will close it.

Best Regards, --V