erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Do not search over all repos when an argument is provided #329

Closed starbelly closed 1 year ago

starbelly commented 1 year ago

When multiple repositories are found, we require a repository argument. However, this is at adds with the whoami command. Originally this was written to perform a whoami for each repository in state, and the bug was introduced when we switched to requiring a repo argument, such that if you have multiple repos defined, this would never work or would only partially work in the best case.

While this small PR is a quick fix, we may alternatively adjust the task to conditionally require the repo argument depending on the task, and in fact I'm leaning more that way :) However, I figured this PR could serve as an issue to discuss both approaches.