search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Warn if publishing package with pre-release dependencies #69

Closed ericmj closed 3 years ago

ericmj commented 7 years ago

If a package has unstable dependencies it is regarded as unstable itself.

The hexpm server will introduce this policy in the future so we should make rebar3 users have a grace period to update their packages until it becomes an error.

starbelly commented 4 years ago

@ericmj I'm pretty sure this has been implemented in hexpm, is this issue stale?

starbelly commented 3 years ago

Closing this as stale. Please re-open if needed.

ericmj commented 3 years ago

It has not been implemented in hexpm yet, we are waiting for rebar3_hex to have shipped with this warning for a while. Sorry for missing your earlier ping.

starbelly commented 3 years ago

@ericmj no worries, re-opened

starbelly commented 3 years ago

@ericmj For clarity, I assume we would determine this via semver?

ericmj commented 3 years ago

Yes, you need to check if any of the dependencies have a pre-release component -foo in their version requirement.

starbelly commented 3 years ago

@ericmj Got it. This should be a warning vs a fatal?

ericmj commented 3 years ago

It should be a warning initially to help users transition. Eventually it will be a server error and then you can make it an error if it will give a better error message than the server provides. We will let you know when it becomes a server error.