erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Use HTTP(S)_PROXY environment variables if defined #72

Closed filmor closed 4 years ago

tsloughter commented 5 years ago

@starbelly you think this is handled now?

starbelly commented 5 years ago

I wasn't sure. Looking at hex_core it is not handled there at a glance, so let's leave this one open. mix/hex provides an http_proxy option and maybe that should be moved into hex_core as well as the ability to override with an env var per the suggestion in this ticket.

starbelly commented 4 years ago

@filmor Many moons later 😁 rebar3 supports http_proxy and https_proxy, it's not upper case which I think is where the disconnect happened and by now you may have sussed that out already. Is this still an issue for you?

filmor commented 4 years ago

Our company scrapped its corporate proxy about 2 years ago :)

I do remember that things got better in-between, though.

starbelly commented 4 years ago

@filmor haha... ok, closing this until it becomes an issue again 😁