search

erlef / rebar3_hex

Rebar3 Hex library
Apache License 2.0
101 stars 49 forks source link

Support Unicode strings in app. description and package metadata #74

Closed g-andrade closed 6 years ago

g-andrade commented 7 years ago

Hi,

I caught this upon trying to publish a package which included a (>255) Unicode codepoint in the application description - it triggered a crash.

g-andrade commented 7 years ago

I do have some reservations about how wild it can get if any symbol is allowed; if you think it best, it's feasible to restrict codepoints to specific Unicode classes. On the other hand, one could argue that it's rather be up to the final destination to do so (hex.pm), and hopefully they're already filtering out most irrelevant symbols, emoji and visual abuses on their side.

g-andrade commented 7 years ago

[bump] What do you think?

tsloughter commented 6 years ago

Thanks! Sorry I forgot to merge this.

tsloughter commented 6 years ago

And right, for now I'd prefer to assume hex.pm will do the necessary filtering if it doesn't want certain symbols.