search

erlef / security-wg

Repo for the Security Working Group
https://erlef.github.io/security-wg/
192 stars 17 forks source link

Add Phoenix Application Security Best Practices #28

Closed maennchen closed 10 months ago

voltone commented 10 months ago

Looking good, thanks a lot! I quickly glanced over it and saw a few spelling/grammar issues that I had previously missed. I'll try to go over everything sometime this week.

voltone commented 10 months ago

Should this be called "Phoenix Application Security Best Practices", or do we want to make it more generic, like "Web Application Security Best Practices for BEAM languages"? @realcorvus

voltone commented 10 months ago

Heads-up to @josevalim and @chrismccord: this is a new guide being published by the EEF Security WG, for now mostly focussed on Plug and Phoenix. The first daft will likely be announced publicly at ElixirConf US next week. Comments, suggestions and corrections are most welcome!

maennchen commented 10 months ago

@voltone / @realcorvus I've changed the title and added SEO keywords to help with the indexing of the document.

josevalim commented 10 months ago

Sorry for the delay, just two minor comments. This is beautifully done and well written. I will add links to it from Phoenix official docs.

maennchen commented 10 months ago

@josevalim Thanks for the review. I'll open a new PR with the changes :)

maennchen commented 10 months ago

Follow up: https://github.com/erlef/security-wg/pull/30