Bad spec definition causes dialyzer error

erlsci / iso8601

An ISO 8601 date formating and parsing library for Erlang

MIT License

130 stars 93 forks source link

Closed cabol closed 7 years ago

cabol commented 7 years ago

The spec located in the file https://github.com/erlsci/iso8601/blob/master/src/iso8601.erl#L41 is wrong. The function allows either string() or binary(), so probably it is a better option to use iodata() instead. This causes that dialyzer fails.

oubiwann commented 7 years ago

Thanks for the heads-up!

oubiwann commented 7 years ago

I've updated the spec for parse and parse_exact. Let me know if that fixes it for you.

cabol commented 7 years ago

Great! Thanks! :)

oubiwann commented 7 years ago

I'm going to go ahead and close this -- if the fix didn't work, feel free to reopen!