search

erlsci / iso8601

An ISO 8601 date formating and parsing library for Erlang
MIT License
130 stars 93 forks source link

Fix tests #51

Closed paulo-ferraz-oliveira closed 4 years ago

paulo-ferraz-oliveira commented 4 years ago

If I understand this correctly, the previous change (53bd46f) was accepted as OK, which means that the fix I propose (following that change, incomplete) will not be surprising.

At the same time, I extend the Travis/Erlang versions to use, as to guarantee code checks are as "updated" as possible.

Note: tests are failing for (older) Erlang/OTP 15, 16, and 17, but the Travis logs aren't helping much.

oubiwann commented 4 years ago

I guess the question I have here is which is more appropriate: trunc or round?

paulo-ferraz-oliveira commented 4 years ago

I guess the question I have here is which is more appropriate: trunc or round?

I asked myself the same question, initially, which is why my Pull Request's description was expressed as it was ("the code was accepted, thus the question was previously answered"). I'm no ISO 8601 expert so cannot presume to reply appropriately. I'm just the guy who completed the previous code change :D

oubiwann commented 4 years ago

Okay, let's go with it for now :-) If there are objections, reasons to go back to round, I'm sure we'll see a PR for that ;-)