erlsci / iso8601

An ISO 8601 date formating and parsing library for Erlang
MIT License
130 stars 93 forks source link

Be stricter on static analysis (via dialyzer) #56

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

[edited original description]

Added more to the dialyzer config.

oubiwann commented 3 years ago

Could you update / rebase? I only added unknown -- you added more:

    {warnings, [
        unknown,
        unmatched_returns,
        error_handling,
        underspecs
    ]}

Would love to see this contribution come in 😄

oubiwann commented 3 years ago

Oh, hey -- I also have incorrect subject/verb agreement here:

Could you change this:

 %% This group of types are from calendar.erl; we need to use some of them 

To this?

 %% This group of types is from calendar.erl; we need to use some of them 
paulo-ferraz-oliveira commented 3 years ago

Sure. Give me a few minutes.

paulo-ferraz-oliveira commented 3 years ago

Done and done.

paulo-ferraz-oliveira commented 3 years ago

Wait, something's off here. I didn't change that many files. Must've something to do with the renaming of branch master.

Edit: yeah, I changed the base branch. Now it's better.

oubiwann commented 3 years ago

Yay! Looks like you got it fixed :-)

Thanks a bunch!