Rename `maybe` type to `undefined_or` to avoid clashing with maybe stm in OTP27

erlsci / iso8601

An ISO 8601 date formating and parsing library for Erlang

MIT License

130 stars 93 forks source link

Rename `maybe` type to `undefined_or` to avoid clashing with maybe stm in OTP27 #62

Closed asakura closed 4 months ago

asakura commented 7 months ago

subj

nixxquality commented 4 months ago

OTP27 released yesterday, would be nice to see this merged :)

cocoa-xu commented 4 months ago

Hi thanks for the great library! Just had the same issue when compiling a library depends on this one:

===> Analyzing applications...
===> Compiling iso8601
===> Compiling src/iso8601.erl failed
src/iso8601.erl:38:16: syntax error before: '::'
src/iso8601.erl:367:18: syntax error before: 'maybe'

It'd be great to see this merged. :)

dsrosario commented 4 months ago

@oubiwann, is it possible to have a release with this PR, please?

oubiwann commented 4 months ago

Oh no, I never saw this! Sorry everyone!!! :-(((( Reviewing now ... will merge and re-release ASAP.