search

erlware / rebar_vsn_plugin

Provides a more reasonable versioning scheme then the rebar standard 'git' vsn extension
17 stars 14 forks source link

fix a couple of bugs in rebar_vsn_plugin #12

Closed ericbmerritt closed 11 years ago

ericbmerritt commented 11 years ago

The previous patch has already been commited. so we can't actually merge with that. You don't change published history. I am actually wondering how it got merged when the build failed :/

ericbmerritt commented 11 years ago

Semver treats integers as integers. Refs are not expected to be treated as integers. This causes some problems from time to time. This seams to be the easiest way to solve that problem.

Basically, what happens is the ec_semver parser strips leading zeros. which causes problems in comparison. This gets rid of the short term problem, but we might want to do something smarter in ec_semver as well.