search

erlware / rebar_vsn_plugin

Provides a more reasonable versioning scheme then the rebar standard 'git' vsn extension
17 stars 14 forks source link

Fixed to work in conjunction with releases #18

Closed ztmr closed 11 years ago

ztmr commented 11 years ago

When the OTP release mechanism is involved, rebar_vsn_plugin fails on reltool.config so that's what we've fixed here.

We also changed the autogenerated comment in the resulting .app file to let people know that it was generated by this plugin. Since we don't expect anybody to edit this (generated) file, Emacs mode settings are not necessary there and was removed thus.

To be honest, I originally wanted to submit pull request that contains only the first commit (a5db014) but GitHub does not allow me to make a pull-request from anything else than from the master's HEAD :-(

ericbmerritt commented 11 years ago

@ztmr over all just minor comments. However, you do need to rebase on the latest version of the plugin.

ztmr commented 11 years ago

ah, that's good idea (to rebase) :-) just a second. BTW, the changes are quite old so I had no idea there are coding style incompatibilities when I submitted the pull request :-(

ztmr commented 11 years ago

Well, this should be better...

ericbmerritt commented 11 years ago

@ztmr no worries on needing to respond to comment. My pull requests (which other erlware guys review) almost always have things that need fixing as well. btw, still a couple of minor pieces of commented out code left.

ericbmerritt commented 11 years ago

finally squash b91b706 and 9b19399. Let me know if this gets too annoying for you. I can always take these patches and make the changes myself.

ericbmerritt commented 11 years ago

@ztmr this looks good. I will try to grab some time to test it. However, it probably wont be before tomorrow.

jwilberding commented 11 years ago

@ztmr Thanks for the patches, much appreciated!