search

erlware / rebar_vsn_plugin

Provides a more reasonable versioning scheme then the rebar standard 'git' vsn extension
17 stars 14 forks source link

Is this repo still maintained? #24

Closed radekg closed 9 years ago

radekg commented 9 years ago

Is this repo still maintained?

ericbmerritt commented 9 years ago

It is. It just hasn't needed much change for a very long time.

radekg commented 9 years ago

Cool, I was asking because of the hanging pull request for which there is no action for a long time. Great work btw. I'm wondering, would you consider accepting a PR which would read current version from a VERSION file?

ericbmerritt commented 9 years ago

Now that is just due to githubs bad notification scheme. Its only recently that I got my mail rules setup well enough to see notifications :/

Well, the main goal of this is to be able to produce a valid semver. It does that right now by leveraging git. The problem with a version file is that there is no easy way to ensure that it is valid. That is that there is only ever one version for one change. It may be possible to take the version in the version file as a base and look for the last commit that changed it and then conver that to a patch version. That would probably be accetable and then we are only replacing the tag with a version in the version file while still retaining the invariant that every version is immutable.

radekg commented 9 years ago

Sounds reasonable. Thank you for the explanation.