erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
697 stars 232 forks source link

Add proper configuration enabling coverage analysis #510

Closed lrascao closed 8 years ago

tsloughter commented 8 years ago

Great, will merge when travis is done.

lrascao commented 8 years ago

This will need a new rebar3 from rebar3/#1334, i'll put a separate PR for it

tsloughter commented 8 years ago

Oh hm, crap, why is rebar3 still included in this repo...

lrascao commented 8 years ago

We could add a Makefile that downloads it on demand, is there a rebar3 nightly build?

ferd commented 8 years ago

There's a stable build instead, which might be nicer? https://s3.amazonaws.com/rebar3/rebar3 -- we were discussing the addition of a nightly (or latest-commit) build on IRC. I guess we could do it, but would need to give it a different name to prevent crushing the file.

lrascao commented 8 years ago

Maybe in relx's specific case the nightly would be best since they are so tightly coupled, but yes it would definitely need a different name

tsloughter commented 8 years ago

No need for a makefile :), it can be done in the travis config.

lrascao commented 8 years ago

ok, separate PR or go with this one?

tsloughter commented 8 years ago

Eh, either way is fine.

lrascao commented 8 years ago

latest stable rebar3 is now being fetched

tsloughter commented 8 years ago

Perfect, is this good to merge now?

lrascao commented 8 years ago

yep, good to go