search

erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
697 stars 232 forks source link

export_all in rlx_goal.erl #573

Closed sirihansen closed 7 years ago

sirihansen commented 7 years ago

In OTP-20.0, there will by default be a warning for the use of -compile(export_all).

Since relx uses compile option warnings_as_errors, the compilation now always fails for rlx_goal.erl when using the master branch of OTP (which is now pre-OTP-20.0).

lrascao commented 7 years ago

@tsloughter remember the reason behind the need for the export_all? all tests pass without it

sirihansen commented 7 years ago

@lrascao If you think there is a real reason for keeping it, you could add -compile(nowarn_export_all).

sirihansen commented 7 years ago

Hi, just checking... is there any progress on this? Would be nice to have so we can compile rebar3 with the OTP master branch without modifying relx locally :) Thanks!

lrascao commented 7 years ago

hey, sorry for the delay (busy with other stuff), i'll ping @tsloughter so we merge #574 asap

lrascao commented 7 years ago

closing via #574