Closed macpie closed 6 years ago
Ah, crap! We did add that :(. Ugh, now I wish we hadn't. It wasn't an issue when Erlang didn't respect SIGTERM...
Going to have to mull this over.
Yes OTP catching SIGTERM
is nice. Nevertheless doing console -noshell -noinput
is ok for me.
Thanks for looking!
Hm, looks like this could be fixed in 19.3.2:
OTP-14358 Application(s): erts Related Id(s): OTP-14085
The +Bi command line argument of erl erroneously caused
SIGTERM to be ignored by the VM as well as of all its
child processes. This bug was introduced in erts
version 8.3.
@tsloughter sweet will give it a try
fixed indeed
Since OPT 19.3
So I wanted to pair that with
docker stop
command to get a proper stop for my application.docker stop
It is recommended to use foreground with docker, problem is, it does not seems to catch the
SIGTERM
. I then realized thatforeground
is using the+Bd
flag. Which seems to interfere with the ability to catch theSIGTERM
.Does
foreground
really need that flag? Should there be an extra command for this case?PS: I fixed this by using
console
and flags_build/default/rel/app/bin/legacy console -noshell -noinput
which I find acceptable. The only difference, that I could find, betweenconsole
andforeground
are those 3 flags-noshell -noinput +Bd