erlware / relx

Sane, simple release creation for Erlang

http://erlware.github.io/relx

Apache License 2.0

697 stars 232 forks source link

Only print lines for os var that are set #586

Closed expelledboy closed 7 years ago

expelledboy commented 7 years ago

Would prefer just using bash echo eval trick, which would allow specifying default etc, but this atleast allows setting the default in application env and optionally configuring if ENV var are set.

expelledboy commented 7 years ago

prefer my changes over #499

532 seems far too complicated

expelledboy commented 7 years ago

Just downloaded the latest version of relx, and just figured this wasnt merged.

@tsloughter @lrascao Just wanted to let you know that completing this review will close 3 PRs, others linked above. Doesnt have to be this one, as they all achieve the same thing. ✌️

lrascao commented 7 years ago

@expelledboy could you rebase onto master so we can get this merged?

expelledboy commented 7 years ago

@lrascao done