erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
697 stars 232 forks source link

dev_mode false issue with sys.config.orig #604

Closed tsloughter closed 6 years ago

tsloughter commented 7 years ago

Opening this so I don't forget but still need to dig in to the problem to investigate.

Basically I noticed that changes to my config/sys_prod.config were not being included when I ran the release after a rebar3 as prod release. I then checked and found that the sys.config under the prod profile was correct after the rebar3 as prod release but then overwritten when the release is run and sys.config.orig is copied over sys.config.

So it seems something needs to be done when a release is rebuilt to remove sys.config.org?

ferd commented 7 years ago

Could alternatively prime both sys.config and sys.config.orig at once I guess?

tsloughter commented 6 years ago

I think we'll just want to ignore this issue as it won't be a problem come OTP21 and its support for sys.config.src.

tsloughter commented 6 years ago

Marking wontfix and will wait to close until I know the OTP21 way of doing things is working.

tsloughter commented 6 years ago

Closing since the latest relx supports sys_config_src.