Extend adding extra args from vm.args to install_upgrade.escript

erlware / relx

Sane, simple release creation for Erlang

http://erlware.github.io/relx

Apache License 2.0

697 stars 232 forks source link

Extend adding extra args from vm.args to install_upgrade.escript #642

Closed konyaris closed 6 years ago

konyaris commented 6 years ago

Related to #640. In #640 vm.args are provided to noodetool escript. I have done similar changes for install_upgrade.escript.

ferd commented 6 years ago

just to be sure, the -sname from vm.args is not provided to the nodetool, right? Otherwise it would be impossible for it to connect to a running node.

lrascao commented 6 years ago

you mean with remote_console?

ferd commented 6 years ago

yeah

lrascao commented 6 years ago

Seems to be good, i've added a test that checks explicitly for this though