search

erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
697 stars 232 forks source link

rebar3 crash on individual overlay settings per release #645

Closed eshubin closed 6 years ago

eshubin commented 6 years ago

rebar3 release command crashes when overlay or sys_config section in relx is added into a specific release in rebar.config.

{relx, [{release, { myapp, "0.1.0" },
         [myapp,
          sasl],
          {sys_config, "./config/sys.config"}
          },

        {vm_args, "./config/vm.args"},

        {dev_mode, true},
        {include_erts, false},

        {extended_start_script, true}].

myapp.zip Archive contains crashdump and report together with source code.

ferd commented 6 years ago

Have you tried with {sys_config, ...} in a list instead of as a bare tuple?

eshubin commented 6 years ago

yes, that works, but if you have multiple releases with different sys.config need to make it configurable per release.

tsloughter commented 6 years ago

He means have you tried:

{relx, [{release, { myapp, "0.1.0" },
         [myapp,
          sasl],
          [{sys_config, "./config/sys.config"}]
          },

        {vm_args, "./config/vm.args"},

        {dev_mode, true},
        {include_erts, false},

        {extended_start_script, true}].
eshubin commented 6 years ago

that fixes the problem, although not obvious from documentation.

2018-04-04 17:56 GMT+03:00 Tristan Sloughter notifications@github.com:

He means have you tried:

{relx, [{release, { myapp, "0.1.0" }, [myapp, sasl], [{sys_config, "./config/sys.config"}] },

    {vm_args, "./config/vm.args"},

    {dev_mode, true},
    {include_erts, false},

    {extended_start_script, true}].

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/erlware/relx/issues/645#issuecomment-378630042, or mute the thread https://github.com/notifications/unsubscribe-auth/ABo8oQuycJIJ_8TbE7m_5C-PEpUSa5Hpks5tlN8QgaJpZM4TFewB .

eshubin commented 6 years ago

Oh, sorry. It is in the list in the doc.

2018-04-04 19:02 GMT+03:00 Eugene Shubin ev.shuba@gmail.com:

that fixes the problem, although not obvious from documentation.

2018-04-04 17:56 GMT+03:00 Tristan Sloughter notifications@github.com:

He means have you tried:

{relx, [{release, { myapp, "0.1.0" }, [myapp, sasl], [{sys_config, "./config/sys.config"}] },

    {vm_args, "./config/vm.args"},

    {dev_mode, true},
    {include_erts, false},

    {extended_start_script, true}].

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/erlware/relx/issues/645#issuecomment-378630042, or mute the thread https://github.com/notifications/unsubscribe-auth/ABo8oQuycJIJ_8TbE7m_5C-PEpUSa5Hpks5tlN8QgaJpZM4TFewB .

eshubin commented 6 years ago

Shall we use "let it crash principle" on wrong config file and close the issue?