erlware / relx

Sane, simple release creation for Erlang

http://erlware.github.io/relx

Apache License 2.0

697 stars 232 forks source link

add -heart to args not to be copied to nodetool #653

Closed juhlig closed 6 years ago

juhlig commented 6 years ago

The current version of extended_bin copies flags from vm.args to nodetool. The flags excluded from copying did not consider the -heart flag, which in turn causes some confusing output from heart when nodetool is used later on (ping, remote_console, stop, ...):

heart_beat_kill_pid = 4010
pong
heart: Wed May 30 16:05:11 2018: Erlang has closed.
heart: Wed May 30 16:05:11 2018: Would reboot. Terminating.

This PR adds the -heart flag to the flags to be excluded.

Thanks to @essen for helping in finding the reason for this issue :)

juhlig commented 6 years ago

... the check failures for R15 and 16 are not related to this PR.

lrascao commented 6 years ago

654 is brewing right now to drop support for R15,16, could you rebase when it gets merged?

juhlig commented 6 years ago

Hm, now OSX is failing, but it has passed before. The passage in the tests that causes the failures are present just like this in most of the other extended_bin_SUITE tests and work.

lrascao commented 6 years ago

@juhlig only custom_status_script and extension_script are failing in OSX, are you able to debug it? if not i can take a look

juhlig commented 6 years ago

@lrascao unfortunatley, I don't have OSX available for debugging, so no. As I see it from the commit history, the checks, along with some others, started failing with the commit immediately before mine. As I further see, the checks seem to be passing now?

lrascao commented 6 years ago

yeah, something weird happened there, anyway all good now, thanks!