search

erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
697 stars 232 forks source link

Make {goals, ...} option add goals to release depsolver. #668

Closed ElectronicRU closed 5 years ago

ElectronicRU commented 6 years ago

Additionally, provides parsing for in-config goals, and better goal merging.

Closes #571.

This reverts commit 0ffe8cd1a2a4e039a48d1096fc250b3f6bd3dcd1.

tsloughter commented 6 years ago

@ElectronicRU sorry I didn't get to this earlier. Can you explain what the "better goal merging" refers to? The patch looks larger than I'd expect for just including in-config goals into the release resolving. I'll try to go over it closer in the morning.

tsloughter commented 6 years ago

Also curious, do you use constraint solving with goals? It is something I've always kind of wanted to just remove.

tsloughter commented 5 years ago

@ElectronicRU ping?

tsloughter commented 5 years ago

@ElectronicRU can you rebase this? I finally did understand what is going on here and why it is needed and was hoping to merge it for the next release.

tsloughter commented 5 years ago

Nevermind, fixed the conflict. Once the tests pass I'll merge.