search

erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
697 stars 232 forks source link

allow specify additional providers via api and cli calls #676

Closed velimir closed 5 years ago

lrascao commented 5 years ago

can you provide a bit of context on the use-case here?

velimir commented 5 years ago

@lrascao I worked on a plugin for rebar3, which was supposed to add a custom release assembler. To get all necessary information about discovered release I had to write relx provider. Currently if one wants to add custom assembler through rebar3 plugin, relx provider has to be specified in rebar3 config (relx section), which means that rebar3 plugin has to modify config on a fly as there's no option to pass this config through command line interface. This PR adds this option. Ideally I would like to have a command line interface that accepts all available relx config variables.

tsloughter commented 5 years ago

Ah, hm, this is probably good. I've of wanted to simplify the relx side and not need things like this, but will likely merge this soon and it'll ensure I make this possible in rebar3 before removing the support from relx in a major version when that time comes.

velimir commented 5 years ago

Shall we make all options available through the interface?

Grigory Starinkin

On 20 Feb 2019, at 23:22, Tristan Sloughter notifications@github.com wrote:

Ah, hm, this is probably good. I've of wanted to simplify the relx side and not need things like this, but will likely merge this soon and it'll ensure I make this possible in rebar3 before removing the support from relx in a major version when that time comes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

tsloughter commented 5 years ago

@velimir yea, that would be good.