search

erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
697 stars 232 forks source link

Enable passing arguments with spaces to extensions #682

Closed lucafavatella closed 5 years ago

lucafavatella commented 5 years ago

Hi,

Is passing arguments with spaces to extensions not possible on purpose? Would you consider a patch supporting that? I did not look yet into how easy it would be to add a test in relx for this case.

I was testing passing arguments with spaces to a rebar3 extension and I was not managing to do so until I amended manually the relx extended bin itself in my OTP release (rebar3 3.5.0 hence relx 3.24.3, though the script seems not changed much in master in this regard). I re-applied these changes to git so to propose them to you though I did not perform extensive testing on this patch.

lrascao commented 5 years ago

Hi,

Is passing arguments with spaces to extensions not possible on purpose? Would you consider a patch supporting that?

Sure, that would be great, you guys are the only users of this feature i've known so far so any improvements you might have are more than welcome. OSX travis test was failing, i've restarted to see if it was just a transient thing

lucafavatella commented 5 years ago

Thanks for taking care of this. I did not arrive at proposing test as I had to deprioritize this.