search

erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
697 stars 232 forks source link

Boot script name is different after tarring #709

Closed tsloughter closed 4 years ago

tsloughter commented 5 years ago

Currently systools make_tar renames the boot script to start.boot from relname.boot. It can be confusing that unless you build a tarball and unpack it you won't be able to do certain thing like install/upgrade with release_handler since it requires the name be start.

I created an issue in the OTP bug tracker: https://bugs.erlang.org/browse/ERL-859 It has been a couple months with no response so I'll have to try poking people to get an answer.

One option is to do nothing. Or do what Jose did in mix release and always rename to start.boot. This would mean no longer using systools:make_tar when running tar but that isn't much of a loss since we already have to unpack the tar and repackage it to include overlay shit.

I guess another would be to find out if OTP team would accept a patch to systools to not only support the boot file always being named start but also to have a way to specify the overlay files to include when running make_tar so we don't have to repackage it.

ferd commented 5 years ago

would it make sense to just run an additional copy + rename on the boot file to make a non-tarred directory upgradable? It's a little pain point we've found the hard way with teams at work where all of a sudden your whole test cycle for hot code loading requires bundling tarballs and unbundling them, rather than just playing around with the existing commands people were used to.

tsloughter commented 5 years ago

Yea, it might be, that is what Jose did for mix release. I was hoping to hear back from someone on the OTP team first.

tsloughter commented 5 years ago

Pinging @garazdawi :). Do you have any background on this or know who I should ping in the Jira issue or here?

garazdawi commented 5 years ago

It is Siri that would know. She's been super overloaded lately though, which is probably why she's not looked at the jira ticket yet.

tsloughter commented 5 years ago

@garazdawi ah ok, thanks. I won't try pinging her then.

tsloughter commented 4 years ago

Now in master, for relx 4.0.0, the release will always copy the boot script to start.boot