search

erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
697 stars 232 forks source link

multiple attach support #737

Closed c-bik closed 4 years ago

c-bik commented 5 years ago

Hi,

It seems like currently in windows attaching simultaneously to two releases running in background is not supported.

For example, if there are more than one app installed (e.g. bin\app1.cmd install, bin\app2.cmd install etc), it is not possible to attach to both of them simultaneously. Calling bin\app1.cmd attach followed bin\app2.cmd attach results second remshell crash immediately. I think the hardcoded rmsh node name (console) is used in the code below, is the reason. https://github.com/erlware/relx/blob/f6bdffcd9bff0b62f3b7fd7bbf3db034f05fbd66/priv/templates/extended_bin_windows#L331-L336

and perhaps something like the following can fix it

-remsh ... %node_type% console_%node_name%

Is this correct thinking / understanding?

I can PR this if I am on the right track.

tsloughter commented 5 years ago

A PR would be great, you are on the right track. If you look at extended_bin you'll see a random name is used for those nodes.

c-bik commented 5 years ago

@tsloughter

A PR would be great, you are on the right track. If you look at extended_bin you'll see a random name is used for those nodes.

Done #738.

c-bik commented 5 years ago

@tsloughter Did you get a chance to have a look at PR #738?