Correctly delete symlinks on windows (resolves #801)

erlware / relx

Sane, simple release creation for Erlang

http://erlware.github.io/relx

Apache License 2.0

697 stars 232 forks source link

Correctly delete symlinks on windows (resolves #801) #802

Closed reganheath closed 4 years ago

reganheath commented 4 years ago

Ensure we use file:del_dir() for directory symlinks on windows (while continuing to use file:delete() on other platforms).

Resolves #801

reganheath commented 4 years ago

I think this is good, thanks! Had me running in loops at first because remove/1 used to be used just to call remove/2 and now remove/2 calls remove/1 :)

LOL, yeah, I wanted the recursive delete to handle nested symlinks so this seemed best :)

tsloughter commented 4 years ago

@reganheath oh my bad, I didn't mention that I've moved 4.0.0 to master now. So open PRs to master from now on. I'll get this one moved over manually.