allow adding a prefix to semver again

erlware / relx

Sane, simple release creation for Erlang

http://erlware.github.io/relx

Apache License 2.0

697 stars 232 forks source link

allow adding a prefix to semver again #864

Closed evanmcc closed 2 years ago

evanmcc commented 3 years ago

This got lost at some point, but I have been relying on it (we've just upgraded from rebar 3.13).

I tried to test it, but it doesn't actually work completely because when this is compiled as a rebar3 library application, -D unicode_str (which should happen because of this: https://github.com/erlang/rebar3/blob/master/rebar.config#L38) doesn't seem to be defined, causing a fallback to the OTP-19 behavior. This should work, but I haven't been able to confirm that it actually does. Maybe with the actual release pathway instead of bootstrap?

evanmcc commented 3 years ago

I don't think that this is mergable; it seems like the meaning of this tuple has changed since 3.13 in several incompatible ways:

git is now a synonym for semver (it used to mean what {git, short} means now)
{semver, Prefix} no longer uses Prefix
relx_string:trim/3 is broken for trim strings longer than 1 character, which it used to support
it's now impossible to mix and match release types when you use profiles to overload the release type (i.e. {git, short} in the top level relx tuple overidden with semver in a profile will always crash)

evanmcc commented 3 years ago

as of https://github.com/erlware/relx/pull/864/commits/00a02abc9396031a710c35d99eaf79dc178673ec this fixes the string trim problem and the prefix issue, but I await input about the change to what git means. I'll work on resolving the crashes and adding some tests before I move this back out of draft.